-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sagemaker Data Quality, Model Quality, Model Explainability Job Definitions + Compilation, Processing Jobs #9464
Sagemaker Data Quality, Model Quality, Model Explainability Job Definitions + Compilation, Processing Jobs #9464
Conversation
{'StatusEquals': 'InProgress'}])) | ||
|
||
def resources(self, query=None): | ||
for q in self.queries: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this block feels duplicated a lot, feels like its ripe for being extracted to a utility function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separate pr though in that context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed as #9469
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Closes #9462 , #9461, #9437, #9440, #9421