-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include c7n awscc in image #9521
Include c7n awscc in image #9521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, we should also regenerate the docker images, but lgtm on the python changes.
@kapilt, Shouldn't the images be generated upon merging the PR? LMK if there is anything to do on my side to close this PR |
its a makefile target on generating the docker files from using the script ( |
@kapilt can I get a review please, thanks !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm
Addressing the issue #9417