Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include c7n awscc in image #9521

Merged
merged 11 commits into from
Jun 2, 2024

Conversation

syed-awais-ali
Copy link
Contributor

@syed-awais-ali syed-awais-ali commented May 20, 2024

Addressing the issue #9417

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, we should also regenerate the docker images, but lgtm on the python changes.

@syed-awais-ali
Copy link
Contributor Author

@kapilt, Shouldn't the images be generated upon merging the PR? LMK if there is anything to do on my side to close this PR

@kapilt
Copy link
Collaborator

kapilt commented May 21, 2024

its a makefile target on generating the docker files from using the script (make geo-docker), its manual atm for the run, thanks for the pr.

@syed-awais-ali
Copy link
Contributor Author

@kapilt can I get a review please, thanks !!

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@kapilt kapilt merged commit c4e7a4a into cloud-custodian:main Jun 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants