-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object lock configuration to augment table #9532
base: main
Are you sure you want to change the base?
Add object lock configuration to augment table #9532
Conversation
dmytro-afanasiev
commented
May 22, 2024
•
edited
edited
this should definitely be a separate filter, we're trying to slim augment table not add to it for s3, re not forcing api calls when they aren't explicitly needed for the policy. |
changed to value filter |
return super().process(resources, event) | ||
|
||
def __call__(self, r): | ||
if self.annotate: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaics given the class value for annotate = true, there's no need for the conditional here.
schema = type_schema('lock-configuration', rinherit=ValueFilter.schema) | ||
permissions = ('s3:GetBucketObjectLockConfiguration',) | ||
annotate = True | ||
annotation_key = 'ObjectLockConfiguration' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally want a c7n: prefix on annotation keys to distinguish from native attributes.