Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for tools in CI #999

Merged
merged 1 commit into from Mar 12, 2017
Merged

Run tests for tools in CI #999

merged 1 commit into from Mar 12, 2017

Conversation

chadwhitacre
Copy link
Contributor

Library changes in #986 broke the mailer. We have no tests for the mailer, but even if we did, we don't run what tests we do have for tools in CI. Let's start with that.

@chadwhitacre
Copy link
Contributor Author

Alright, sentry tests are showing up in both Drone and Travis.

@chadwhitacre
Copy link
Contributor Author

Rebased, was 716162eb9a71b1f7aa23da52e65ebb04ba60d1b4.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@chadwhitacre
Copy link
Contributor Author

Rebased, was a6d0695d51291181ea1c8e438f03017738e964fc.

@chadwhitacre chadwhitacre added this to Review in blue team Mar 7, 2017
@chadwhitacre
Copy link
Contributor Author

@kapilt Bump. Ready to merge, ya?

@kapilt kapilt merged commit 2010a07 into cloud-custodian:master Mar 12, 2017
@chadwhitacre chadwhitacre deleted the run-tool-tests branch March 12, 2017 12:50
@chadwhitacre chadwhitacre moved this from Review to Done in blue team Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants