Add setup.py back to fix cross compiling ARM64 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
reviewed
Oct 20, 2022
|
could you add a description on what the intent of this pr is |
|
@kapilt Description added |
sontek
changed the title
pipenv
|
I don't have access to merge so you'll have to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM64 builds are broken currently because
poetrydoes not support platform specific builds currently. The issues for it are here:The issues that relate to this problem are:
python-poetry/poetry#2051
python-poetry/poetry#2613
with the code for the bug it has here:
https://github.com/python-poetry/poetry-core/blob/main/src/poetry/core/masonry/builders/wheel.py#L298-L312
Basically
cibuildwheelis sending a couple of environment variables thatsetuptoolsuses normally to decide platform/arch/etc.These are not respected by poetry and so if you need to cross-compile libraries
poetryis currently not the build tool for this. I think we could look at https://github.com/pypa/hatch as an alternative or send a PR to poetry to fix this. But for now this gets us back usingsetup.pyso cross compiling works.