Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --tls flag by default for redis client & add unit test #67

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • add --tls flag by default for redis client
  • add unit test

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

The TLS flag is necessary for connecting to our Redis instances because they are all configured to use TLS, as documented here: https://cloud.gov/docs/services/aws-elasticache/#connecting-to-your-elasticache-service-locally

@markdboyd markdboyd requested a review from a team July 13, 2023 18:46
Copy link

@cweibel cweibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds tls flag and test functionality

@markdboyd markdboyd merged commit 092a812 into main Jul 13, 2023
1 check passed
@markdboyd markdboyd deleted the add-tls-flag-for-redis branch July 13, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants