This repository has been archived by the owner on May 19, 2020. It is now read-only.
Fix Navbar & Sidebar Issues #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2015 11:10
Since the function was moved to a directive, it can't find anything. Once we start doing unit tests on directives, we will move the test there.
jcscottiii
force-pushed
the
directives-view
branch
from
1a0f0ce
to
239bc2b
Compare
Current coverage is
|
Closed
This was referenced Aug 12, 2015
jcscottiii
added a commit
that referenced
this pull request
Aug 12, 2015
Fix Navbar & Sidebar Issues This PR fixes: Allow the navbar to determine if the user is logged in. Moves the sidebar to the navbar for small screens Removes the sidebar if the user is logged out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior, the navbar could not determine if it was for a logged in user vs not. this fixes that