Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions, silence deprecations #107

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Bump versions, silence deprecations #107

merged 1 commit into from
Jun 3, 2024

Conversation

bengerman13
Copy link
Contributor

warnings + plan

  • this breaks ./dev watch-tests because the watcher library doesn't get toml. I'll follow up with a PR to move to the other pytest watcher later
  • my plan is to work through the sqlalchemy warnings one at a time, to help lower the change size going forward

Changes proposed in this pull request:

  • add function to upgrade dependencies
  • upgrade dependencies
  • fix one sqlalchemy deprecation warning (sqlalchemy.orm.relation -> sqlalchemy.orm.relationship)
  • silence other sqlalchemy deprecation warnings

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

addresses some dependency warnings that dependabot is shouting about.

- add function to upgrade dependencies
- upgrade dependencies
- fix one sqlalchemy deprecation warning
- silence other sqlalchemy deprecation warnings
@bengerman13 bengerman13 requested a review from a team June 3, 2024 20:48
@bengerman13 bengerman13 merged commit e6777ef into main Jun 3, 2024
1 check passed
@bengerman13 bengerman13 deleted the bb/version-bumps branch June 3, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants