Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests #98

Merged
merged 15 commits into from
Feb 20, 2024
Merged

Fix CI tests #98

merged 15 commits into from
Feb 20, 2024

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Feb 20, 2024

Changes proposed in this pull request:

Related to #97

  • Updating Python version to match version in CI
  • Fix bandit code scanning tests for CI
  • Update setup environment script to install editable package for unit testing
  • Removed unnecessary step from e2e tests
  • Update proxy code to make certs optional for local testing
  • Update config unit tests for new certificate properties

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

These changes are test facing and have no direct security impact

@markdboyd markdboyd changed the title Fix ci Fix CI tests Feb 20, 2024
@markdboyd markdboyd requested a review from a team February 20, 2024 20:51
@markdboyd markdboyd merged commit 4edd64c into main Feb 20, 2024
1 check passed
@markdboyd markdboyd deleted the fix-ci branch February 20, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants