Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize app name in web interface #3756

Merged
merged 17 commits into from
Jan 26, 2022

Conversation

svenaas
Copy link
Contributor

@svenaas svenaas commented Jan 25, 2022

Changes proposed in this pull request:

  • Front end uses of "Federalist" or "Pages" are parametrized based on environment, including
    • Web application text
    • Web page title
    • Web page meta tags
    • Web page body DOM class (added to facilitate parametrizing CSS background image)
    • Application logo images
    • Messages, alerts, and warnings
    • Email subject lines
    • Support email address (pages-support@cloud.gov / federalist-support@gsa.gov) (except in uaaInvite.js which is only relevant to Pages)
  • Numerous changes in testing to make things work locally (usually Pages), on Circle (Federalist), and on Concourse (Pages).

This is work toward #3709

security considerations

None

@svenaas svenaas changed the title Parameterize app name in Federalist web interface Parameterize app name in web interface Jan 25, 2022
@svenaas
Copy link
Contributor Author

svenaas commented Jan 25, 2022

I want to do a round of spot-checking on this locally in the browser before I ask for a code review.

@svenaas svenaas marked this pull request as ready for review January 26, 2022 16:11
@svenaas svenaas requested a review from a team January 26, 2022 16:19
Copy link
Contributor

@davemcorwin davemcorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming nothing breaks, this looks ok to me. We can play around in the staging envs as well.

It's not worth changing here, but it's worth evaluating whether or not we need the app name at all in a lot of the client-facing messaging, we probably could have just dropped it in a bunch of places. 🤷

@svenaas svenaas merged commit 9dcc664 into staging Jan 26, 2022
@svenaas svenaas deleted the 3709-parameterize-app-name-in-federalist-web branch January 26, 2022 18:02
davemcorwin pushed a commit that referenced this pull request Jun 1, 2022
…alist-web

Parameterize app name in web interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants