Correctly set site engine when adding a site

[svenaas]

Changes proposed in this pull request:

• Actually passes the engine parameter through when creating new sites.

This is intended to address #3753

security considerations

None

[svenaas]

Weird. Failed on Concourse but not on local. It's one of these:

  1) Domain Service
       .updateSiteForProvisionedDomain()
         sets the domain name on the associated site if not previously set:
     Error: Timeout of 2500ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/app/test/api/unit/services/Domain.test.js)
      at listOnTimeout (node:internal/timers:557:17)
      at processTimers (node:internal/timers:500:7)

In the hopes that it is actually a timeout because Concourse is being slow, I am trying it again.

[svenaas]

Well, shoot. Same timeout.

The tests still pass on my local machine (where, like Concourse, PRODUCT is set to 'Pages') as well as on CircleCI (where PRODUCT is set to 'Federalist').

The timeout happens in the DomainService unit test during a call to DomainService.updateSiteForProvisionedDomain which should have zero connection to the change this branch introduces in the site controller.

Any clever ideas, @18F/federalist-admins?

[davemcorwin]

looks like something I probably borked....