Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only configure UAA auth if feature flag is set #3774

Merged

Conversation

davemcorwin
Copy link
Contributor

Changes proposed in this pull request:

  • Only configure UAA if feature flag is set

This enables Federalist to run without UAA creds since they are not required.

security considerations

None

@davemcorwin davemcorwin requested a review from a team February 9, 2022 19:52
@davemcorwin davemcorwin self-assigned this Feb 9, 2022
Copy link
Contributor

@svenaas svenaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks OK

@svenaas
Copy link
Contributor

svenaas commented Feb 9, 2022

Except for that build-test-deploy failure, of course...

@davemcorwin
Copy link
Contributor Author

admin Merging as Concourse/pages deployment will be addressed later.

@davemcorwin davemcorwin merged commit 5921838 into staging Feb 9, 2022
@davemcorwin davemcorwin deleted the dc/make-uaa-auth-config-conditional-on-feature-flag branch February 9, 2022 20:50
@svenaas svenaas mentioned this pull request Feb 16, 2022
davemcorwin added a commit that referenced this pull request Jun 1, 2022
…-on-feature-flag

Only configure UAA auth if feature flag is set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants