Add Github auth for queues ui #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
must fix tests.... |
Tests aren't running because we aren't pulling in redis creds for bull-board. |
apburnes
reviewed
Feb 16, 2022
| if (process.env.NODE_ENV === 'production') { | ||
| const cfenv = require('cfenv'); // eslint-disable-line global-require | ||
| const appEnv = cfenv.getAppEnv(); | ||
| const { |
There was a problem hiding this comment.
I cannot hydrate these when running the tests locally. We use the config/test.js convention for other parts of the app but bull-board is a bit different since it may also be broken out into its own entity through something like the monorepo.
There was a problem hiding this comment.
yeah, i started going down a bit of a yak-shave in my head for how we should handle env vars and config...
apburnes
approved these changes
Feb 16, 2022
davemcorwin
added a commit
that referenced
this pull request
Jun 1, 2022
Add Github auth for queues ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
FederalistLocalGH org and OAuth apps for local developmentsecurity considerations
Allowing Github authentication for queues UI based on membership in
federalist-adminsGH org, same as admin interface.Other thoughts
For the config that has been updated, the architecture reflects where I think we should be going with configuration.
process.env) should be source of truth so we can easily configure on CG, Docker, and local.VCAP_APPLICATIONand VCAP_SERVICES) to environment variables. Typically this would be with a.profilefile, but since the Queues UI isn't deployed all by it's lonesome quite yet, we useenv.js` to do this.config.js) for easy consumption.