Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create example using postcss #287

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Create example using postcss #287

wants to merge 5 commits into from

Conversation

hursey013
Copy link
Contributor

Changes proposed in this pull request:

  • Removed dependencies execjs, autoprefixer-rails, jekyll-assets, from Gemfile
  • Added postcss and postcss plugins to compile sass and autoprefix
  • Added node_modules plugin to Jekyll to allow easier referencing/copying of assets from uswds npm package
  • Adjusted {% asset %} tags to use native html tags

Security considerations

Removes unmaintained dependencies.

@hursey013
Copy link
Contributor Author

Not totally sure what to do with this... maybe just leave it as a branch for now until we revisit the future of Jekyll starter templates?

@drewbo
Copy link
Contributor

drewbo commented Nov 18, 2022

Does anything prevent us from using this as the new base template? If we think it's more reliable/maintainable without jekyll-assets it would be a good replacement for now

@hursey013
Copy link
Contributor Author

Does anything prevent us from using this as the new base template? If we think it's more reliable/maintainable without jekyll-assets it would be a good replacement for now

It could be, however it seems like USWDS 3 continues to recommend using gulp, so I'm not sure if we want to follow that approach, or deviate from it with PostCSS (or another build tool, webpack?). Either way, probably worth talking about it more before making a switch so we can talk about whats most sustainable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants