This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Cleanup reactive states handling and expose replset relation parameter #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2017 21:33
Instead of setting new states - remove them, otherwise, a situation will be possible where two states are set indicating that the relation data is both available and not available. Signed-off-by: Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
Some applications require replicaset parameter appended to the mongodb connection string. For example, zaqar-server does not allow connections to individual mongodb instances without replset. The service simply fails after start. The mongodb charm itself already exports that argument and does a relation_set. However, reactive charms that might use this interface are not able to use this parameter without the introduced code. Also, for granularity, a new state is introduced to distinguish the states where only a connection string is available from the state where replset is available. Signed-off-by: Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is attempts to make state handling better by deleting set_state("*.removed") calls and adding calls to actually remove .available states.
The second patch exposes the replset parameter of a relation which is already present in the mongodb charm code:
https://bazaar.launchpad.net/~charmers/charms/trusty/mongodb/trunk/view/head:/hooks/hooks.py#L1141
Some applications (like zaqar) require replicated or sharded configurations only and do not work with standalone instances which is why the change is needed.