Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud hypervisor might exit before all http replies are sent #6247

Closed
alex-matei opened this issue Feb 28, 2024 · 0 comments · Fixed by #6248
Closed

Cloud hypervisor might exit before all http replies are sent #6247

alex-matei opened this issue Feb 28, 2024 · 0 comments · Fixed by #6248

Comments

@alex-matei
Copy link
Contributor

alex-matei commented Feb 28, 2024

Describe the bug
When cloud-hypervisor receives a vmm.shutdown request it doesn't wait until the reply for it is actually flushed by the HTTP worker thread.

To Reproduce
Start many (40+) cloud-hypervisor processes in parallel and send each a vmm.shutdown request.

Version

v38.0

Did you build from source, if so build command line (e.g. features):

VM configuration

What command line did you run (or JSON config data):

Guest OS version details:

Host OS version details:

Logs

Output of cloud-hypervisor -v from either standard error or via --log-file:

Linux kernel output:

alex-matei added a commit to UiPath/cloud-hypervisor that referenced this issue Feb 28, 2024
This commit ensures that the HttpApi thread flushes all the responses
before the application shuts down. Without this step, in case of a
VmmShutdown request the application might terminate before the
thread sends a response.

Fixes: cloud-hypervisor#6247

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
alex-matei added a commit to UiPath/cloud-hypervisor that referenced this issue Feb 28, 2024
This commit ensures that the HttpApi thread flushes all the responses
before the application shuts down. Without this step, in case of a
VmmShutdown request the application might terminate before the
thread sends a response.

Fixes: cloud-hypervisor#6247

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
alex-matei added a commit to UiPath/cloud-hypervisor that referenced this issue Feb 28, 2024
This commit ensures that the HttpApi thread flushes all the responses
before the application shuts down. Without this step, in case of a
VmmShutdown request the application might terminate before the
thread sends a response.

Fixes: cloud-hypervisor#6247

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
alex-matei added a commit to UiPath/cloud-hypervisor that referenced this issue Feb 29, 2024
This commit ensures that the HttpApi thread flushes all the responses
before the application shuts down. Without this step, in case of a
VmmShutdown request the application might terminate before the
thread sends a response.

Fixes: cloud-hypervisor#6247

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
github-merge-queue bot pushed a commit that referenced this issue Feb 29, 2024
This commit ensures that the HttpApi thread flushes all the responses
before the application shuts down. Without this step, in case of a
VmmShutdown request the application might terminate before the
thread sends a response.

Fixes: #6247

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

1 participant