Do not start signal thread is there is no need. #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuangel
force-pushed
the
zhuangel/dev
branch
2 times, most recently
from
21fec86
to
cfc2f99
Compare
rbradford
requested changes
Feb 27, 2023
Now cloud hypervisor will start signal thread to catch SIGWINCH signal, cloud hypervisor then will resize the guest console via vconsole. This patch skip starting signal thread when there is no need to resize guest console, such as console is not configured. Signed-off-by: Yong He <alexyonghe@tencent.com>
zhuangel
force-pushed
the
zhuangel/dev
branch
from
cfc2f99
to
09a3cba
Compare
Thanks, I missed 'nice clean-up', I have updated the PR, only include the SIGWINCH signal related thread revise. |
rbradford
approved these changes
Feb 28, 2023
likebreath
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now cloud hypervisor will start two signal thread to catch host side signals, then do something when specified signal is come, such as:
catch SIGWINCH, to resize virito-console.
This patch skip start such thread, is there is no need.