Handle APIC EOI message for MSHV #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Liu <liuwe@microsoft.com>
jinankjain
approved these changes
Aug 16, 2023
| @@ -562,6 +562,18 @@ impl cpu::Vcpu for MshvVcpu { | |||
| debug!("Exception Info {:?}", { info.exception_vector }); | |||
| Ok(cpu::VmExit::Ignore) | |||
| } | |||
| hv_message_type_HVMSG_X64_APIC_EOI => { | |||
There was a problem hiding this comment.
Anyway we get an exit here? I think we are not.
There was a problem hiding this comment.
During our testing we encountered this exit here while passing through a PCI device to guest, disabling MSIX support.
There was a problem hiding this comment.
I think we can only get this if we enable legacy PCI INTx support. It uses level-triggered interrupt, which requires explicitly acking the vector.
There was a problem hiding this comment.
We have PCI INTx support for VFIO and vfio-user devices.
praveen-pk
reviewed
Aug 16, 2023
praveen-pk
approved these changes
Aug 16, 2023
russell-islam
approved these changes
Aug 18, 2023
rbradford
approved these changes
Aug 21, 2023
likebreath
added
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is discovered in our testing that MSHV didn't handle this message.
In general I don't think Cloud Hypervisor handles level-triggered interrupts well. KVM code is missing resamplefd code. That's something to be fixed later.