-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various typos + typos configuration + CI #5720
Conversation
51ea0c0
to
2e2c029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
.typos.toml
Outdated
Ded = "Ded" # GUIDed | ||
ba = "ba" | ||
Cros = "Cros" # CrosVM | ||
Dake = "Dake" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what's special about that name and not any of the others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would think the tool would be able to identify that pretty common email format (Name Name <email>
) and not flag it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, unfortunately it does not.
0185cee
to
6365684
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contributions. Generally look good to me. Couple of cosmetic comments about the commit style. Please refer our contribution doc for complete details [1].
- Please merge the last commit about crosvm to the fist commit;
- Please rename the first commit to:
misc: Fix various typos
; - Please capitalize the first world for each commit subject after the component name.
[1] https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/CONTRIBUTING.md
I updated the PR. I hope, we are good to go now. If not, let me know. |
Please rebase. |
This is a preparation to run the typos utility on the repo. Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
This fixes all typos found by the typos utility with respect to the config file. Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
This adds the typos utility as dedicated CI step. Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
Done. |
This fixes all typos I've found using the https://github.com/crate-ci/typos utility.
Furthermore, it adds an additional step to execute
typos
in GitHub CI.