Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various typos + typos configuration + CI #5720

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

phip1611
Copy link
Contributor

@phip1611 phip1611 commented Aug 31, 2023

This fixes all typos I've found using the https://github.com/crate-ci/typos utility.
Furthermore, it adds an additional step to execute typos in GitHub CI.

@phip1611 phip1611 requested a review from a team as a code owner August 31, 2023 13:06
@phip1611 phip1611 force-pushed the typos branch 4 times, most recently from 51ea0c0 to 2e2c029 Compare August 31, 2023 13:56
Copy link
Member

@rbradford rbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

.typos.toml Outdated Show resolved Hide resolved
.typos.toml Outdated Show resolved Hide resolved
.typos.toml Outdated Show resolved Hide resolved
.typos.toml Outdated
Ded = "Ded" # GUIDed
ba = "ba"
Cros = "Cros" # CrosVM
Dake = "Dake"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what's special about that name and not any of the others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would think the tool would be able to identify that pretty common email format (Name Name <email>) and not flag it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, unfortunately it does not.

@phip1611
Copy link
Contributor Author

.typos.toml Outdated Show resolved Hide resolved
Copy link
Member

@likebreath likebreath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contributions. Generally look good to me. Couple of cosmetic comments about the commit style. Please refer our contribution doc for complete details [1].

  1. Please merge the last commit about crosvm to the fist commit;
  2. Please rename the first commit to: misc: Fix various typos;
  3. Please capitalize the first world for each commit subject after the component name.

[1] https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/CONTRIBUTING.md

@phip1611
Copy link
Contributor Author

phip1611 commented Sep 8, 2023

Thank you for the contributions. Generally look good to me. Couple of cosmetic comments about the commit style. Please refer our contribution doc for complete details [1].

  1. Please merge the last commit about crosvm to the fist commit;
  2. Please rename the first commit to: misc: Fix various typos;
  3. Please capitalize the first world for each commit subject after the component name.

[1] https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/CONTRIBUTING.md

I updated the PR. I hope, we are good to go now. If not, let me know.

@rbradford
Copy link
Member

Please rebase.

This is a preparation to run the typos utility on the repo.

Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
This fixes all typos found by the typos utility with respect to the config file.

Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
This adds the typos utility as dedicated CI step.

Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
@phip1611
Copy link
Contributor Author

phip1611 commented Sep 9, 2023

Please rebase.

Done.

@rbradford rbradford enabled auto-merge (rebase) September 9, 2023 08:55
@rbradford rbradford merged commit 83f3b34 into cloud-hypervisor:main Sep 9, 2023
21 of 22 checks passed
@likebreath likebreath added the CI CI issues like flaky tests and new pipeline/worker to add label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI issues like flaky tests and new pipeline/worker to add
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants