block: Probe with block size alignment #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rbradford
commented
Sep 3, 2023
rbradford
commented
- block: Move DiskTopology to common code
- block: Ensure probing reads are block size aligned
It doens't make sense to limit this to the async_io module and import across modules so place in default create module. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
rbradford
force-pushed
the
2023-09-03-block-aligned-probing
branch
from
66e441c
to
d4d6c15
Compare
This is necessary for O_DIRECT based use of raw block devices which may require access at a larger block size than that of a sector (512 bytes.) Fixes: cloud-hypervisor#5722 Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
rbradford
force-pushed
the
2023-09-03-block-aligned-probing
branch
from
d4d6c15
to
1708cb9
Compare
|
Thanks @rbradford. I just tested this branch with a 4k logical block size NVMe disk and it worked like a charm :). Once this is merged, I will close this issue. |
likebreath
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.