scripts: Change features_build variable type to array #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbradford
reviewed
Feb 28, 2024
scripts/dev_cli.sh
Outdated
| @@ -298,7 +298,7 @@ cmd_build() { | |||
| --env RUSTFLAGS="$rustflags" \ | |||
| --env TARGET_CC="$target_cc" \ | |||
| "$CTR_IMAGE" \ | |||
| cargo build --all "$features_build" \ | |||
| cargo build --all $features_build \ | |||
There was a problem hiding this comment.
This change is triggering the shell script check - maybe it should be $(features_build) - @rmstoi ?
There was a problem hiding this comment.
I changed the features_build var type to an array. It should pass the checks now.
There was a problem hiding this comment.
This could be solved by using bash parameter substitution to pass null string (and not quotes) to cargo if features_build is null or unset. For example:
- cargo build --all "$features_build" \
+ cargo build --all ${features_build:+"$features_build"} \
Changing features_build to an array should also work.
alex-matei
force-pushed
the
fix/dev-cli-build
branch
2 times, most recently
from
40400d3
to
f052974
Compare
alex-matei
changed the title
Because of double quotes the current value is passed as a single argument with a space in it to cargo. This commit changes it to an array so each element is passed as a different arguments. Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
alex-matei
force-pushed
the
fix/dev-cli-build
branch
from
f052974
to
94373f4
Compare
alex-matei
changed the title
rbradford
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of double quotes the current value is passed as a single argument with a space in it to cargo. This commit changes it to an array so each element is passed as a different arguments.