Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add SGX, VFIO and rate limit testing to MQ #6252

Conversation

rbradford
Copy link
Member

Run these workflows as part of the merge queue to help improve testing
coverage.

Signed-off-by: Rob Bradford rbradford@rivosinc.com

@rbradford rbradford requested a review from a team as a code owner February 29, 2024 07:38
@rbradford rbradford force-pushed the 2024-02-29-add-vfio-sgx-rate-limit-to-merge-group branch from c95178d to 8c17750 Compare February 29, 2024 07:48
@likebreath
Copy link
Member

likebreath commented Feb 29, 2024

We will need to make these workers required, right? Just added these workers as required for merging to main.

@likebreath likebreath added this pull request to the merge queue Feb 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 29, 2024
@likebreath
Copy link
Member

@rbradford I added a commit to fix the directory permissions on the bare-metal workers. PTAL.

.github/workflows/integration-rate-limiter.yaml Outdated Show resolved Hide resolved
.github/workflows/integration-sgx.yaml Outdated Show resolved Hide resolved
.github/workflows/integration-vfio.yaml Outdated Show resolved Hide resolved
@rbradford rbradford force-pushed the 2024-02-29-add-vfio-sgx-rate-limit-to-merge-group branch from 45e2576 to c5c48c2 Compare March 1, 2024 08:00
@rbradford
Copy link
Member Author

@likebreath Oops, I missed your other comment about the permissions fix - can you create a new PR - I guess we need the same for ARM64?

likebreath and others added 2 commits March 1, 2024 08:04
When a bare-metal worker is canceled, its workspace can be left with
files owned by the root user as a result of running tests from our
container. This patch add a step to fix workspace permissions for such
case before checking out code.

Signed-off-by: Bo Chen <chen.bo@intel.com>
Run these workflows as part of the merge queue to help improve testing
coverage.

Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
@rbradford rbradford force-pushed the 2024-02-29-add-vfio-sgx-rate-limit-to-merge-group branch from c5c48c2 to 2b82560 Compare March 1, 2024 08:04
@rbradford
Copy link
Member Author

@likebreath Oops, I missed your other comment about the permissions fix - can you create a new PR - I guess we need the same for ARM64?

No matter - I was able to find the commit and cherry-picked it.

@rbradford rbradford enabled auto-merge March 1, 2024 08:04
@rbradford rbradford added this pull request to the merge queue Mar 1, 2024
Merged via the queue into cloud-hypervisor:main with commit cdafe53 Mar 1, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants