virtio-device: Detaching endpoint from old domain in virtio-iommu #6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarp-crusoe
force-pushed
the
nested-virtualization-reboot
branch
from
64cf7ed
to
d1746dc
Compare
rbradford
reviewed
Mar 18, 2024
There was a problem hiding this comment.
@acarp-crusoe There's a lot of whitespace changes in this commit - perhaps you could drop those - or explain why they're there (lots of additions and removals...)
acarp-crusoe
force-pushed
the
nested-virtualization-reboot
branch
2 times, most recently
from
8c3d7d4
to
57459ab
Compare
Apologies I didn't notice those whitespace changes, they should all be removed |
acarp-crusoe
force-pushed
the
nested-virtualization-reboot
branch
4 times, most recently
from
6b96d58
to
8aa9aca
Compare
acarp-crusoe
force-pushed
the
nested-virtualization-reboot
branch
5 times, most recently
from
d5b79cb
to
9c7506c
Compare
acarp-crusoe
force-pushed
the
nested-virtualization-reboot
branch
from
9c7506c
to
de67b89
Compare
Ensures that any endpoints already attached to the domain are properly mapped to a new endpoint on said endpoint's attach request. This is done by search for all previous mappings in the domain and then issuing map requests for the newly attached endpoint. Signed-off-by: Andrew Carp <acarp@crusoeenergy.com>
Properly detach a device from a domain if that device is already attached to another domain on an attach request (following section 5.13.6.3.2 of the virtio-iommu spec). Resolves nested virtualization reboot. Signed-off-by: Andrew Carp <acarp@crusoeenergy.com>
acarp-crusoe
force-pushed
the
nested-virtualization-reboot
branch
from
de67b89
to
dbb0d93
Compare
|
@thomasbarrett - when you get back next week can you take a look and give an approval if this looks good? |
|
This looks good to me :) |
rbradford
approved these changes
Apr 1, 2024
You should be able to use the GitHub UI to give reviews - even though the checkmark may be grey rather than green, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly detach a device from a domain if that device is already attached to another domain on an attach request (following section 5.13.6.3.2 of the virtio-iommu spec) - resolves nested virtualization reboot