-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openapi: add missing pvpanic property to VmConfig #6372
Conversation
Thank you for contribution - please look at the surrounding commits for an indication of the appropriate commit message style. |
@rbradford Fixed, I should have paid attention to commit naming 😅 |
@lucas-jacques Not a problem. There are details here - https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/CONTRIBUTING.md including the requirement for DOC (i.e. "Signed-Off-By".) You can have git add that for you with "-s". |
dc351db
to
5193b0e
Compare
The git message lint is not a problem but the DCO check is still failing - I think you have github masking your email address? |
@rbradford Yes I just disabled this setting, it should be good now |
Unfortunately I think you need to |
Signed-off-by: Lucas Jacques <contact@lucasjacques.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rmstoi - can you add "openapi" prefix to the list of approved prefixes - thanks! |
108af5a
See cloud-hypervisor#6372 Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
See #6372 Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
Hello, if i'm not wrong, the pvpanic boolean is missing in the api specification on the VmConfig model.