Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: add missing pvpanic property to VmConfig #6372

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

lucas-jacques
Copy link
Contributor

@lucas-jacques lucas-jacques commented Apr 8, 2024

Hello, if i'm not wrong, the pvpanic boolean is missing in the api specification on the VmConfig model.

@lucas-jacques lucas-jacques requested a review from a team as a code owner April 8, 2024 13:30
@rbradford
Copy link
Member

Thank you for contribution - please look at the surrounding commits for an indication of the appropriate commit message style.

@lucas-jacques lucas-jacques changed the title add pvpanic parameter to vmconfig in api spec vmm: add missing pvpanic VmConfig propery in api spec Apr 8, 2024
@lucas-jacques lucas-jacques changed the title vmm: add missing pvpanic VmConfig propery in api spec openapi: add missing pvpanic property to VmConfig Apr 8, 2024
@lucas-jacques
Copy link
Contributor Author

@rbradford Fixed, I should have paid attention to commit naming 😅

@rbradford
Copy link
Member

@lucas-jacques Not a problem. There are details here - https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/CONTRIBUTING.md including the requirement for DOC (i.e. "Signed-Off-By".) You can have git add that for you with "-s".

@lucas-jacques lucas-jacques force-pushed the patch-1 branch 2 times, most recently from dc351db to 5193b0e Compare April 8, 2024 15:17
@rbradford
Copy link
Member

The git message lint is not a problem but the DCO check is still failing - I think you have github masking your email address?

@lucas-jacques
Copy link
Contributor Author

@rbradford Yes I just disabled this setting, it should be good now

@rbradford
Copy link
Member

@rbradford Yes I just disabled this setting, it should be good now

Unfortunately I think you need to git commit --amend --reset-author -s and repush.

Signed-off-by: Lucas Jacques <contact@lucasjacques.com>
Copy link
Contributor

@up2wing up2wing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jinankjain jinankjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbradford rbradford enabled auto-merge April 9, 2024 08:51
@rbradford
Copy link
Member

rbradford commented Apr 9, 2024

@rmstoi - can you add "openapi" prefix to the list of approved prefixes - thanks!

@rbradford rbradford added this pull request to the merge queue Apr 9, 2024
Merged via the queue into cloud-hypervisor:main with commit 108af5a Apr 9, 2024
30 of 31 checks passed
rmstoi added a commit to rmstoi/cloud-hypervisor that referenced this pull request Apr 9, 2024
See cloud-hypervisor#6372

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
github-merge-queue bot pushed a commit that referenced this pull request Apr 9, 2024
See #6372

Signed-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants