build: Cargo.toml formatting & GitHub Action to check #6453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rbradford
commented
May 8, 2024
rbradford
commented
- build: Add taplo configuration file for Cargo.toml files
- build: Format Cargo.toml files using taplo
- build: Add GitHub action to run taplo for Cargo.toml formatting
This configuration enforces the alphebetical ordering of arrays and keys in the Cargo.toml files. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Run the taplo formatter with the newly added configuration file Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Check that the Cargo.toml files meet the formatting requirements. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
rbradford
force-pushed
the
2024-05-08-cargo-toml-formatting
branch
from
e6e6479
to
a59968b
Compare
This was preventing the Cargo.toml formatter (taplo) from correctly alphabetically ordering. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
likebreath
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.