Add support for HTTP HEAD, POST, DELETE methods are needed to support RESTful API #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Method::Delete, which is needed for device hot-removal. Also fix a clippy warning. Fixes: firecracker-microvm#12 Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
bergwolf
approved these changes
Jan 20, 2021
sameo
approved these changes
Jan 20, 2021
|
@imeoer Could we also add the API extensions to the changelog file? |
Add support for Method::Head and Method::Post, which is needed for RESTful style API, also update related test cases. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
|
@sameo Thanks, already added to CHANGELOG and bump version to |
sameo
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
In general, we need to use these HTTP methods to support RESTful style API:
GET -> Get Resource
HEAD -> Get Resource Metadata
POST -> Create Resource
PUT -> Update Whole Resource
DELETE -> Delete Resource
PATCH -> Update Part Of Resource
Description of Changes
Add support for Method::Head, Method::Post, Method::Delete, which is needed for RESTful style API, also update related test cases.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
git commit -s).unsafecode is properly documented.CHANGELOG.md.