fix: 🧪 owner permission level should be 2 #1255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analysis Details0 Issues
Coverage and Duplications
Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ |
| @@ -36,8 +36,7 @@ export const createRandomDbSetup = ({ nbUsers = 1, nbRepo = 3, envs = basicStage | |||
| project.roles[0].role = projectRoles[0] | |||
| const ownerId = project.roles.find(role => role.role === 'owner')?.userId | |||
|
|
|||
| // @ts-ignore | |||
| project.members = project.roles.map(({ userId, user: { id: _, ...user }, role }) => { | |||
| project.members = project.roles.map(({ userId, user, role }) => { | |||
There was a problem hiding this comment.
On ne se retrouve pas avec 2 fois l'id de l'utilisateur avec cette modification ?
There was a problem hiding this comment.
sous forme d'id et de userId oui
There was a problem hiding this comment.
C'est ce que renvoie notre API ? Si c'est le cas c'est bizarre non ? Et si ça n'est pas le cas est-ce qu'on ne devrait pas plutôt essayer de s'aligner sur le comportement de l'api ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro:
Quel est le comportement actuel ?
Quel est le nouveau comportement ?
Cette PR introduit-elle un breaking change ?
Autres informations