Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

occ app_api:app:unregister rework #127

Merged
merged 9 commits into from
Nov 26, 2023
Merged

occ app_api:app:unregister rework #127

merged 9 commits into from
Nov 26, 2023

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Nov 25, 2023 •
edited
Loading

Fixes #121

  • small actions clean up
  • added basic but very useful tests for "occ app_api:app:unregister"

Changes in behaviour:

  • container of app is always removed
  • volume with data is removed by default, but optionally can be kept
  • app_api does not try to disable ExApp if it is already disabled
  • "--silent" options now means "max silence as possible"
  • added "--force" option to ignore errors if any.

@bigcat88
small actions clean up
d5164be 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
revert commit back
4118f07 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
made env common, as it is equal
bb5fb15 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
reworked "app_api:app:unregister"
63acc05 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
fixed actions with new "unregister" implementation(1)
b964128 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
fixed actions with new "unregister" implementation(2)
db6a9a9 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
fixed actions with new "unregister" implementation(3)
aa342df 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
fixed actions with new "unregister" implementation(4)
afe25c6 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
fixed actions with new "unregister" implementation(5)
f3f664f 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 merged commit 9ce6fc3 into main Nov 26, 2023
26 checks passed
@bigcat88 bigcat88 deleted the unregister-silent-option branch November 26, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey18106 andrey18106 andrey18106 approved these changes

@kyteinsky kyteinsky Awaiting requested review from kyteinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app_api:app:unregister command does not respect silent option
2 participants
@bigcat88 @andrey18106