Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reworked users.get_details #145

Merged
merged 6 commits into from
Oct 14, 2023
Merged

reworked users.get_details #145

merged 6 commits into from
Oct 14, 2023

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Oct 14, 2023

Changes proposed in this pull request:

  • users.get_details renamed to get_user and returns a class instead of a dictionary.
  • Optional argument displayname in users.create renamed to display_name.

Fixed:

  • users.get_details with empty parameter in some cases was raised exception.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #145 (b772e22) into main (3c189b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   99.76%   99.77%           
=======================================
  Files          34       34           
  Lines        2976     3059   +83     
=======================================
+ Hits         2969     3052   +83     
  Misses          7        7           
Files Coverage Δ
nc_py_api/_version.py 100.00% <100.00%> (ø)
nc_py_api/users.py 100.00% <100.00%> (ø)

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 merged commit 700ee3a into main Oct 14, 2023
15 checks passed
@bigcat88 bigcat88 deleted the users-api branch October 14, 2023 13:24
bigcat88 added a commit to cloud-py-api/app_api that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant