Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TaskProcessing): Allow defining custom task types #270

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

provokateurin
Copy link
Contributor

Counter part for cloud-py-api/app_api#324

Signed-off-by: provokateurin <kate@provokateurin.de>
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.69%. Comparing base (000819d) to head (09900fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   94.72%   94.69%   -0.04%     
==========================================
  Files          47       47              
  Lines        5403     5405       +2     
==========================================
  Hits         5118     5118              
- Misses        285      287       +2     
Files Coverage Δ
nc_py_api/ex_app/providers/task_processing.py 40.69% <60.00%> (-0.97%) ⬇️

bigcat88 and others added 2 commits July 13, 2024 21:59
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As currently we did not define classes and enums(and probably will not until API in Server will be in final mature state) - I tested with the simple "custom TaskTypes" and all are working.

Thanks @provokateurin for the PR

@bigcat88 bigcat88 merged commit 22cbea9 into main Jul 13, 2024
19 checks passed
@bigcat88 bigcat88 deleted the feat/task-processing/custom-task-types branch July 13, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants