Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export type instead of export #20

Merged
merged 2 commits into from
Oct 11, 2023
Merged

export type instead of export #20

merged 2 commits into from
Oct 11, 2023

Conversation

jakudlaty
Copy link
Contributor

Hi
I am trying to use Your library with isolatedModules in my tsconfig an this gives me an warning:

node_modules/vue-markdown-render/src/VueMarkdown.ts:3:10 - error TS1205: Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.

export { Options } from 'markdown-it'
              ~~~~~~~

i think it should be

export type { Options } from 'markdown-it'

To provide more compatibility.

Hi
I am trying to use Your library with isolatedModules in my tsconfig an this gives me an warning:

```
node_modules/vue-markdown-render/src/VueMarkdown.ts:3:10 - error TS1205: Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.

export { Options } from 'markdown-it'
              ~~~~~~~
```
i think it should be 
```
export type { Options } from 'markdown-it'
```
To provide more compatibility.
Copy link
Contributor

@p-kuen p-kuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Can you please run pnpm run build for this PR?

@jakudlaty
Copy link
Contributor Author

It builds without problems.

pnpm run build

> vue-markdown-render@2.1.0 build /home/jakudlaty/Devel/vue-markdown-render
> tsc

I see You dont have any CI on your project, You know that github ci is free for opensource projects?
Maybe i could help You create a basic CI worklow which at least runs a npm build for every pull request?

@p-kuen
Copy link
Contributor

p-kuen commented Oct 10, 2023

I see You dont have any CI on your project, You know that github ci is free for opensource projects?

Yes, unfortunately I had no time to implement ci for this project.

I see You dont have any CI on your project, You know that github ci is free for opensource projects? Maybe i could help You create a basic CI worklow which at least runs a npm build for every pull request?

Yes, I would appreciate it a lot if you could create a PR for building the package.

It builds without problems.

Thanks, can you please commit the built files into the PR until we have a running CI?

@jakudlaty
Copy link
Contributor Author

jakudlaty commented Oct 11, 2023

Thanks, can you please commit the built files into the PR until we have a running CI?

done

@p-kuen p-kuen merged commit 74e562f into cloudacy:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants