Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Refactor dashboard provisioning #134

Merged
merged 8 commits into from
Mar 22, 2019
Merged

Refactor dashboard provisioning #134

merged 8 commits into from
Mar 22, 2019

Conversation

paulfantom
Copy link
Member

@paulfantom paulfantom commented Jan 26, 2019

  • do not use rsync (no synchronize module)
  • synchronize dashboards with deployer host by default (when using grafana provisioning system)
  • use temporary directory to store dashboards on deployer
  • increase code readability by
    • grouping parts in blocks
    • refactoring long lines

Fixes #90
Fixes #128

@stale
Copy link

stale bot commented Mar 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 12, 2019
@platan
Copy link

platan commented Mar 16, 2019

A version from this PR works for me (https://github.com/platan/metrics-shields-io-config/blob/master/requirements.yml#L13). Any chances for merge? Can I help you with this PR?

@stale stale bot removed the wontfix This will not be worked on label Mar 16, 2019
@paulfantom
Copy link
Member Author

@platan sorry for delay, can you test if current PR revision works for you?

@platan
Copy link

platan commented Mar 22, 2019

Version c9691b1 works for me.

@paulfantom paulfantom merged commit 2d1ed55 into master Mar 22, 2019
@paulfantom paulfantom deleted the better_provisioning branch March 22, 2019 21:11
@lock
Copy link

lock bot commented Apr 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard provisioning is interactive Use tempfile for /tmp/dashboards
2 participants