This repository has been archived by the owner on May 31, 2023. It is now read-only.
Add support for running in socket mode #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for the presence of the socket when the server is in socket mode
RichardHeelin
force-pushed
the
socket-support
branch
from
20ea363
to
87e7a0f
Compare
Ensure that grafana can write to the directory the socket is in
paulfantom
reviewed
Jul 23, 2019
tasks/preflight.yml
Outdated
| mag: "You need to configure grafana_server.socket when grafana_server.protocol is set to 'socket'" | ||
| when: | ||
| - grafana_server.protocol is defined and grafana_server.protocol == 'socket' | ||
| - grafana_server.socket is undefined or grafana_server.socket == '' |
There was a problem hiding this comment.
Linter complains about lack of newline at the end of this file, could you add it?
Source: https://travis-ci.org/cloudalchemy/ansible-grafana/jobs/558913403#L556-L557
added 2 commits
July 23, 2019 13:24
|
Thanks! 👍 |
cosandr
pushed a commit
to cosandr/ansible-grafana
that referenced
this pull request
Aug 12, 2020
* Added support for running the server in socket mode Check for the presence of the socket when the server is in socket mode * Manage the socket directory permissions Ensure that grafana can write to the directory the socket is in * Ensure newline at end of file * Fixed typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for configuring the server to be used in socket mode, normally when behind a proxy, we need to support checking for the socket file rather than a http/s connection, when checking that grafana is running.