Fix linter

[laurent-indermuehle]

This is an attempt to fix #42

[laurent-indermuehle]

Ok, now the "lint" step passes.
"molecule test -s default --destroy always" still fail, but the error regarding the missing role seems to be resolved.
The new error is:

ERROR! couldn't resolve module/action 'community.docker.docker_container'. This often indicates a misspelling, missing collection, or incorrect module path.

The issue may be explained here: ansible/molecule#2755

Either we try to fix the molecule//collections.yml for 2.9 and 2.10. Or we could skip those versions to use ansible 3.1, 4.7 and 5.4 that are out for a while now.

But for people still on Ansible Automation Platform 1, the supported version is the 2.9...

[laurent-indermuehle]

Ok, now it works up utile this:

TASK [ansible-mysqld_exporter : Ensure mysqld_exporter is enabled on boot] *****
fatal: [bionic]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (systemd) module: started Supported parameters include: daemon_reexec, daemon_reload, enabled, force, masked, name, no_block, scope, state, user"}
fatal: [buster]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (systemd) module: started Supported parameters include: daemon_reexec, daemon_reload, enabled, force, masked, name, no_block, scope, state, user"}
fatal: [centos7]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (systemd) module: started Supported parameters include: daemon_reexec, daemon_reload, enabled, force, masked, name, no_block, scope, state, user"}
fatal: [stretch]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (systemd) module: started Supported parameters include: daemon_reexec, daemon_reload, enabled, force, masked, name, no_block, scope, state, user"}
fatal: [fedora]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (systemd) module: started Supported parameters include: daemon_reexec, daemon_reload, enabled, force, masked, name, no_block, scope, state, user"}
fatal: [xenial]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (systemd) module: started Supported parameters include: daemon_reexec, daemon_reload, enabled, force, masked, name, no_block, scope, state, user"}

But I may have fixed that in PR #40

[laurent-indermuehle]

Mergify now says: The new Mergify configuration is valid

I learned a lot about CircleCI and Github, thanks for that :)

Is there somebody at cloudalchemy who can find the time to review the PR please? @paulfantom maybe?
Many thanks for your roles! They're the first ones I use due to their great quality.

[SuperQ]

We have a bunch of things to fix in our CI right now. The changes are mostly done in our skeleton/automated updates. But we need to get things pushed out to all of the other projects.

I'm planning to do a bit of a hackathon with @paulfantom sometime soon to get things cleaned up.

[laurent-indermuehle]

Thanks for the reply @SuperQ
I look forward to seeing the new CI setup then :)

[laurent-indermuehle]

I've removed the dot after the command 'ansible-lint' because that seems to make it fails to find the yaml files.

Then I had to fix the role path in molecule and a linting problem in prepare.yml

I felt guilty to have PR a non-functional ansible-lint configuration even if you said you're working on your CI.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[laurent-indermuehle]

Not stale

[SuperQ]

This role has been deprecated in favor of a the prometheus-community/ansible collection.