Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

always import install.yml when using local dir #162

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

appliedprivacy
Copy link
Contributor

fixes #160
solution proposed by @paulfantom

@paulfantom
Copy link
Member

paulfantom commented Jun 17, 2020

Apparently, ansible-lint don't like comparisons to empty string (E602 from https://docs.ansible.com/ansible-lint/rules/default_rules.html). I wonder if just ( node_exporter_binary_local_dir ) would work, if not let's exclude E602 in https://github.com/cloudalchemy/ansible-node-exporter/blob/master/.ansible-lint.

@appliedprivacy
Copy link
Contributor Author

you seem to use | length > 0 in other places, ok to use it here as well?

@github-actions github-actions bot added the area/tasks Logic behind ansible role label Jun 17, 2020
@appliedprivacy
Copy link
Contributor Author

The error message does not say much but I assume it fails on 2.9 due to #158.

@paulfantom
Copy link
Member

paulfantom commented Jun 17, 2020

Failure is not related to #158 (that error does not manifest itself when installing ansible via pip). This is typical molecule failure to create test instance.

@paulfantom paulfantom merged commit 7eb009e into cloudalchemy:master Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tasks Logic behind ansible role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node_exporter can not be updated when node_exporter_binary_local_dir is set
2 participants