This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
Allow empty value in config_flags_extra #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Turgon37 Could you also add a test case for this? Here is an alternative test playbook where you can add options to |
|
It's done :) |
paulfantom
approved these changes
Jun 27, 2018
There was a problem hiding this comment.
I'm a little bit supprised that this YAML syntax works (YAML is strange sometimes), but it looks ok. @SuperQ wdyt?
|
Ahh, yea, handling bool flags like this seems ok. |
slomo
pushed a commit
to slomo/ansible-prometheus
that referenced
this pull request
Dec 12, 2018
[patch] Allow empty value in config_flags_extra
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to enable administrative api endpoint using --web.enable-admin-api in prometheus service options but the operation failed because of the ansible mandatory "value" field.
the flag --web.enable-admin-api does not take any value.
According to https://prometheus.io/docs/operating/security/, I've made a fix to allow this