Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

Update label for CriticalDiskSpace alert expression. #202

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Update label for CriticalDiskSpace alert expression. #202

merged 3 commits into from
Apr 24, 2019

Conversation

mjbnz
Copy link
Contributor

@mjbnz mjbnz commented Apr 24, 2019

Label has changed from filesystem to mountpoint in newer versions of node_exporter

Also added /snap mount points to be ignored - squashfs filesystems used on Ubuntu by snapd.

Fixes #201

@mjbnz
Update label for CriticalDiskSpace alert expression.
d80ab55 
Label has changed from `filesystem` to `mountpoint` in newer versions of `node_exporter`

Also added `/snap` mount points to be ignored - squashfs filesystems used on Ubuntu by snapd.
@mjbnz
Change CriticalDiskSpace query to use fstype
1448612 
More reliable than `mountpoint`, and catches other types of special filesystems as well.
@paulfantom
Copy link
Member

tmpfs is as much a "real" filesystem as others so alerts should happen there.
Simple example is using tmpfs for temporary storage for a web application (think wordpress), if it gets full you won't get any upload abilities in application and no alert since CriticalDiskSpace won't be triggered.

@mjbnz
Copy link
Contributor Author

mjbnz commented Apr 24, 2019 •
edited

Ahhh, good point. how about:

mountpoint!~"^/run(/.*|$)",fstype!="squashfs"

(can probably forego fuse fs's - I only stuck that in for /etc/pve on proxmox)

@paulfantom paulfantom mentioned this pull request Apr 24, 2019
Closed
@paulfantom
Copy link
Member

mountpoint!~"^/run(/.*|$)",fstype!~"(squashfs)" looks nice 👍

@mjbnz
Copy link
Contributor Author

mjbnz commented Apr 24, 2019 •
edited

mountpoint!~"^/run(/.*|$)",fstype!~"(squashfs)" looks nice 👍

!~ or != since it's just squashfs ? could add fuse back in if you like - you choose, I'll fix the PR.

@paulfantom
Copy link
Member

Add fuse and let's merge it 😃

@mjbnz
Best of both worlds!
6e2b81b 
* mountpoint!~"^/run(/.*|$)"
  Catches `/run` and subdirs which are tmpfs, but not all tmpfs
* fstype!~"(squashfs|fuse.*)"
  Catches any `squashfs` (always full) or `fuse` filesystems.
@mjbnz
Copy link
Contributor Author

mjbnz commented Apr 24, 2019

Add fuse and let's merge it 😃

Deal, done. ;)

@paulfantom paulfantom merged commit 643327e into cloudalchemy:master Apr 24, 2019
@paulfantom
Copy link
Member

Thanks! 🎉

@mjbnz mjbnz deleted the criticaldiskspace-label-update branch April 24, 2019 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default CriticalDiskSpace alert using wrong label?
2 participants
@mjbnz @paulfantom