Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

Improve checksum fetching #254

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Improve checksum fetching #254

merged 1 commit into from
Jan 20, 2020

Conversation

SuperQ
Copy link
Collaborator

@SuperQ SuperQ commented Dec 27, 2019

  • Fetch checksum list once for all instances.
  • Delegate checksum finder to localhost.

[patch]

Signed-off-by: Ben Kochie superq@gmail.com

@github-actions github-actions bot added the area/tasks Logic behind ansible role label Dec 27, 2019
paulfantom
paulfantom previously approved these changes Dec 29, 2019
Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SuperQ SuperQ force-pushed the superq/local_sums branch 2 times, most recently from a9415b7 to f873138 Compare December 29, 2019 16:45
@github-actions github-actions bot added the area/vars Ansible variables used in role label Dec 29, 2019
defaults/main.yml Outdated Show resolved Hide resolved
tasks/preflight.yml Outdated Show resolved Hide resolved
Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good, just a few nits

* Fetch checksum list once for all instances.
* Delegate checksum finder to localhost.

[patch]

Signed-off-by: Ben Kochie <superq@gmail.com>
Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SuperQ
Copy link
Collaborator Author

SuperQ commented Jan 20, 2020

Grrr, flaky test startup.

@SuperQ SuperQ merged commit 579a5b0 into master Jan 20, 2020
@SuperQ SuperQ deleted the superq/local_sums branch January 20, 2020 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tasks Logic behind ansible role area/vars Ansible variables used in role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants