This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
previously approved these changes
Dec 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SuperQ
force-pushed
the
superq/local_sums
branch
2 times, most recently
from
December 29, 2019 16:45
a9415b7
to
f873138
Compare
paulfantom
reviewed
Dec 31, 2019
paulfantom
reviewed
Dec 31, 2019
paulfantom
suggested changes
Dec 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good, just a few nits
SuperQ
force-pushed
the
superq/local_sums
branch
2 times, most recently
from
January 20, 2020 09:53
2af2546
to
0fd6887
Compare
* Fetch checksum list once for all instances. * Delegate checksum finder to localhost. [patch] Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
superq/local_sums
branch
from
January 20, 2020 10:17
0fd6887
to
5601a4d
Compare
paulfantom
approved these changes
Jan 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grrr, flaky test startup. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[patch]
Signed-off-by: Ben Kochie superq@gmail.com