This repository has been archived by the owner on Sep 19, 2019. It is now read-only.
Allow rpc changes requests to fetch ddoc from local cache #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Companion PR out in https://github.com/cloudant/dbcore/pull/265. |
| #changes_args{dir=Dir} = Args = lists:keyfind(changes_args, 1, Options), | ||
| #changes_args{dir=Dir, filter=Filter} = Args0 = lists:keyfind(changes_args, 1, Options), | ||
| Args = case Filter of | ||
| {fetch, Style, {DbArg, JsonReq, DDocId, FName}} -> |
There was a problem hiding this comment.
Seems like you need a when is_binary(DDocId) here.
There was a problem hiding this comment.
I suppose it wouldn't hurt to add that in, but right now the only caller sends a binary. Do you think it's better to fail loudly with a pattern match error here, or silently skip the fetch command and load the slow way? I think I would honestly rather see this throw a 500 than fail silently back to the slow approach.
There was a problem hiding this comment.
Also I think we should move this to couch_changes as an API function. I don't like introspecting that filter tuple outside of the module that defines it.
chewbranca
force-pushed
the
58187-dont-send-ddocs-over-the-wire
branch
from
99e27ac
to
d0f2081
Compare
|
+1 |
chewbranca
added a commit
that referenced
this pull request
Mar 2, 2016
…wire Allow rpc changes requests to fetch ddoc from local cache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.