New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zones #1

Closed
wants to merge 19 commits into
from

Conversation

Projects
None yet
3 participants
@kocolosk
Member

kocolosk commented Jun 7, 2011

No description provided.

Show outdated Hide outdated src/mem3_nodes.erl
(#full_doc_info{deleted=true}, _, Dict) ->
{ok, Dict};
(#full_doc_info{id=Id}, _, Dict) ->
{ok, #doc{body={Props}}} = couch_db:open_doc(Db, Id),

This comment has been minimized.

@kocolosk

kocolosk Jun 7, 2011

Member

You should pass the #full_doc_info to couch_db:open_doc/2 here to avoid unnecessary btree ops.

Also, just a stylistic point, but what about including the Db in the accumulator instead of inlining the fold function?

@kocolosk

kocolosk Jun 7, 2011

Member

You should pass the #full_doc_info to couch_db:open_doc/2 here to avoid unnecessary btree ops.

Also, just a stylistic point, but what about including the Db in the accumulator instead of inlining the fold function?

This comment has been minimized.

@rnewson

rnewson Jun 9, 2011

Member

I'll do both, though I note that inlining it was a style choice on my part.

@rnewson

rnewson Jun 9, 2011

Member

I'll do both, though I note that inlining it was a style choice on my part.

@kocolosk

This comment has been minimized.

Show comment
Hide comment
@kocolosk

kocolosk Jun 7, 2011

Member

The indentation convention in mem3 is 4 spaces, we'll need to convert the tabs used throughout this patch.

Member

kocolosk commented Jun 7, 2011

The indentation convention in mem3 is 4 spaces, we'll need to convert the tabs used throughout this patch.

@kocolosk

This comment has been minimized.

Show comment
Hide comment
@kocolosk

kocolosk Jun 7, 2011

Member

We'll also want to add a clause to the code_change function in mem3 to convert the existing list to a dictionary

Member

kocolosk commented Jun 7, 2011

We'll also want to add a clause to the code_change function in mem3 to convert the existing list to a dictionary

@bdionne

This comment has been minimized.

Show comment
Hide comment
@bdionne

bdionne Jun 7, 2011

I think this could go into a config file or something. It's the only thing that makes it particular to ec2. This module could then be mem3_choose_simple or maybe mem3_choose_default

I think this could go into a config file or something. It's the only thing that makes it particular to ec2. This module could then be mem3_choose_simple or maybe mem3_choose_default

@kocolosk

This comment has been minimized.

Show comment
Hide comment
@kocolosk

kocolosk Jun 9, 2011

Member

The patch makes the top-level properties of each document in the nodes DB available via mem3:node_info/2, but only the _ec2 variant uses this information when choosing shards for a DB. I'd prefer it if we have an algorithm that uses the "zone" field in the document in the same manner as mem3_choose_ec2 when placing shards but does not try to query the EC2 metadata API to set the content of that field.

Member

kocolosk commented Jun 9, 2011

The patch makes the top-level properties of each document in the nodes DB available via mem3:node_info/2, but only the _ec2 variant uses this information when choosing shards for a DB. I'd prefer it if we have an algorithm that uses the "zone" field in the document in the same manner as mem3_choose_ec2 when placing shards but does not try to query the EC2 metadata API to set the content of that field.

@kocolosk

This comment has been minimized.

Show comment
Hide comment
@kocolosk

kocolosk Aug 11, 2011

Member

Closed by merging the backport_zones branch

94e2d5

Member

kocolosk commented Aug 11, 2011

Closed by merging the backport_zones branch

94e2d5

@kocolosk kocolosk closed this Aug 11, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment