Skip to content
This repository has been archived by the owner on Sep 19, 2019. It is now read-only.

Zones #1

Closed
wants to merge 19 commits into from
Closed

Zones #1

wants to merge 19 commits into from

Conversation

kocolosk
Copy link
Contributor

@kocolosk kocolosk commented Jun 7, 2011

No description provided.

(#full_doc_info{deleted=true}, _, Dict) ->
{ok, Dict};
(#full_doc_info{id=Id}, _, Dict) ->
{ok, #doc{body={Props}}} = couch_db:open_doc(Db, Id),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should pass the #full_doc_info to couch_db:open_doc/2 here to avoid unnecessary btree ops.

Also, just a stylistic point, but what about including the Db in the accumulator instead of inlining the fold function?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do both, though I note that inlining it was a style choice on my part.

@kocolosk
Copy link
Contributor Author

kocolosk commented Jun 7, 2011

The indentation convention in mem3 is 4 spaces, we'll need to convert the tabs used throughout this patch.

@kocolosk
Copy link
Contributor Author

kocolosk commented Jun 7, 2011

We'll also want to add a clause to the code_change function in mem3 to convert the existing list to a dictionary

@kocolosk
Copy link
Contributor Author

kocolosk commented Jun 9, 2011

The patch makes the top-level properties of each document in the nodes DB available via mem3:node_info/2, but only the _ec2 variant uses this information when choosing shards for a DB. I'd prefer it if we have an algorithm that uses the "zone" field in the document in the same manner as mem3_choose_ec2 when placing shards but does not try to query the EC2 metadata API to set the content of that field.

@kocolosk
Copy link
Contributor Author

Closed by merging the backport_zones branch

94e2d5

@kocolosk kocolosk closed this Aug 11, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants