Zones #1
Conversation
(#full_doc_info{deleted=true}, _, Dict) -> | ||
{ok, Dict}; | ||
(#full_doc_info{id=Id}, _, Dict) -> | ||
{ok, #doc{body={Props}}} = couch_db:open_doc(Db, Id), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should pass the #full_doc_info to couch_db:open_doc/2 here to avoid unnecessary btree ops.
Also, just a stylistic point, but what about including the Db in the accumulator instead of inlining the fold function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do both, though I note that inlining it was a style choice on my part.
The indentation convention in mem3 is 4 spaces, we'll need to convert the tabs used throughout this patch. |
We'll also want to add a clause to the code_change function in mem3 to convert the existing list to a dictionary |
The patch makes the top-level properties of each document in the nodes DB available via |
Closed by merging the backport_zones branch |
No description provided.