Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Add common database unit tests #26

Merged
merged 3 commits into from
Nov 4, 2015
Merged

Conversation

alfinkel
Copy link
Contributor

@alfinkel alfinkel commented Nov 2, 2015

What:

We are adding new common CouchDB and Cloudant database tests.

Why:

In order to more accurately test the CouchDatabase and CloudantDatabase class functionality we need to ensure that we have a solid set of unit tests that tests functionality against both CouchDB and Cloudant instances.

How:

  • Add unit tests that are common to both Couch and Cloudant database implementations.
  • Additional Cloudant database specific tests will be added in a future PR.
  • Refactor the account module and introduce a unit test base class in order to consolidate common testing functionality.

reviewer: @gadamc

BugId: 54523

- For use with all db related tests
- Sets up the Account and client for all db related tests
- Contains utility methods common to all tests
Note: Admin Party is currently unsupported so we must create a
CouchDB user for tests to function with a CouchDB instance if one is
not provided.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConfigParser is pretty standard in python: https://docs.python.org/2/library/configparser.html. Can fix it later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added FB Case 55684 (https://cloudant.fogbugz.com/f/cases/55684) to track this.

@gadamc
Copy link
Contributor

gadamc commented Nov 3, 2015

my comments are only questions or suggestions... so +1 otherwise

- These tests are common to both CouchDB and Cloudant testing
- Additional tests will be added for Cloudant specific testing in a
future PR.
alfinkel added a commit that referenced this pull request Nov 4, 2015
@alfinkel alfinkel merged commit 5b0b227 into master Nov 4, 2015
@ricellis ricellis deleted the 54523-add-couchdb-unit-tests branch August 3, 2016 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants