Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Intermittent read timeout #460

Merged
merged 5 commits into from Feb 19, 2020
Merged

Intermittent read timeout #460

merged 5 commits into from Feb 19, 2020

Conversation

ricellis
Copy link
Member

@ricellis ricellis commented Feb 19, 2020

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
  • Completed the PR template below:

Description

Adjust read timeout in intermittently failing test and update test matrices.

1. Steps to reproduce and the simplest code sample possible to demonstrate the issue

Run tests.unit.replicator_tests.ReplicatorTests.test_timeout_in_create_replication

2. What you expected to happen

Test to pass.

3. What actually happened

It intermittently fails.

Approach

Change the timeout from .5 to (30,5) - this means the connect timeout stays at the default 30s instead of also being reduced to .5s and the read timeout is increased from .5 seconds to 5 s. Whilst this means the test takes longer to run, it is much more reliable.

Schema & API Changes

  • "No change"

Security and Privacy

  • "No change"

Testing

  • Modified existing tests because to change timeout to resolve intermittent failure.
  • Modified test matrix to remove Python 2 as it is EOL.
  • Modified test matrix for CouchDB version
    • 1.7.1 -> 1.7.2 (although Couch 1.x is EOL, we'll still run these tests until the next major I think)
      • Had to fix tests.unit.client_tests.ClientTests.test_create_invalid_database_name as a result of this change
    • 2.1.1 -> 2.3.1
      • Had to fix test set up special casing version as a result of this change.

Monitoring and Logging

  • "No change"

@ricellis ricellis self-assigned this Feb 19, 2020
Python 2 is EOL, removed from matrix.
Updated CouchDB patch versions.
The HEAD on an invalid DB name that doesn't exist returns a 400 in 1.7.2 but a 404 in 1.7.1 and 2.x
@@ -3,14 +3,13 @@ sudo: required
language: python

python:
- "2.7"
Copy link
Member

@emlaver emlaver Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for removing 2.7 now that it's EOL.

@ricellis ricellis merged commit 084f575 into master Feb 19, 2020
@ricellis ricellis deleted the intermittent-read-timeout branch February 19, 2020 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants