This repository has been archived by the owner on Mar 11, 2022. It is now read-only.
Apply 2.x specific tests to CouchDB 3.x #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
During testing on new CouchDB 3.x, I've noticed that some tests are skipped. These tests only run in a CouchDB 2.x.
This PR extends the version checking to 3.x for those tests.
Approach
Schema & API Changes
No change
Security and Privacy
No change
Testing
The following tests should pass in Couchdb 2.x and 3.x
changes_dbChangesMustSuccessfullyReturnWithSeqInterval
changes_selector
changes_selectorAndMoreThanLimitNumberOfDocs
pull_filterDocIdsFromAnimalDb_twoDocShouldBePulled
pull_filterSelectorMammalFromAnimalDbUsingParameterizedFilter_eightDocShouldBePulled
pull_filterSelectorBirdFromAnimalDb_twoDocShouldBePulled
pull_filterSelectorMammalFromAnimalDbUsingParameterizedFilter_eightDocShouldBePulled
pull_filterSelectorSmallFromAnimalDbUsingIntegerFilter_eightDocShouldBePulled
pull_filterSelectorSmallFromAnimalDbUsingNullFilter_eightDocShouldBePulled
Monitoring and Logging
No change