Detect and remove stale connections #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to detect stale daemons, we'll record the timestamp of certain IO events: * last received request * last submitted request * last received reply * queue timestamp for each async IO request Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
We'll include the following timestamps in the wnbd-client stats output: * last received request * last submitted request * last received reply
petrutlucian94
force-pushed
the
stale_conn
branch
from
dd77fb0
to
94d6425
Compare
petrutlucian94
commented
Jun 7, 2023
Storport resets the lun after hitting request timeouts. However, it never actually removes the disk. Having a stale disk can be troublesome, leading to an unresponsive host in certain situations (e.g. cache deadlocks, hanging persistent reservation requests, etc). For this reason, we'll detect stale connections and disconnect the disk. This feature along with the timeouts are configurable. By default, we'll consider a connection to be stale if at least one request older than 15s got aborted and if no IO reply was received in the last minute. Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
The PR test job installs qemu in order to run NBD tests. The issue is that we're hitting checksum errors with the latest Qemu choco build (released 1 week ago), for which reason we'll switch to the previous version. Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94
force-pushed
the
stale_conn
branch
from
55af770
to
d6bbe3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storport resets the lun after hitting request timeouts. However,
it never actually removes the disk. Having a stale disk can be
troublesome, leading to an unresponsive host in certain situations
(e.g. cache deadlocks, hanging persistent reservation
requests, etc).
For this reason, we'll detect stale connections and disconnect
the disk. This feature along with the timeouts are configurable.
By default, we'll consider a connection to be stale if at least one
request older than 15s got aborted and if no IO reply was received
in the last minute.
At the same time, we'll include the following timestamps in the
wnbd-client.exe statsoutput:Signed-off-by: Lucian Petrut lpetrut@cloudbasesolutions.com