client: properly handle negative time counters #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"wnbd-client stats" now reports a few time counters, such as "TimeSinceLastReceivedReqMs". Those counters have a ~15ms accuracy, so for really short intervals we can end up with a negative value when comparing with the current timestamp: TimeSinceLastReceivedReqMs : 18446744073709551604 TimeSinceLastSubmittedReqMs : 18446744073709551604 TimeSinceLastReplyMs : 18446744073709551604 This patch will translate such intervals to 0. Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"wnbd-client stats" now reports a few time counters, such as "TimeSinceLastReceivedReqMs". Those counters have a ~15ms accuracy, so for really short intervals we can end up with a negative value when comparing with the current timestamp:
This patch will translate such intervals to 0.