Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n-zh pages for contribute module #118

Merged
merged 1 commit into from
May 8, 2024

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Apr 26, 2024

closes: #ISSUE_Number


Change logs

Add i18n-zh pages for contribute module.

Contributor's checklist

Here are some reminders before you submit your pull request:

  • Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
  • Learn the code contribution and doc contribution guides for better collaboration.
  • Make sure that your changes deployment preview is successful.
  • List your communications in the GitHub Issues or Discussions (if has or needed).
  • Feel free to ask for the @cloudberrydb/doc team or other people to help review and approve.

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for cloudberrydb ready!

Name Link
🔨 Latest commit 67907be
🔍 Latest deploy log https://app.netlify.com/sites/cloudberrydb/deploys/6639f4e6e3536600082b5385
😎 Deploy Preview https://deploy-preview-118--cloudberrydb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tuhaihe tuhaihe force-pushed the contribute_i18n-zh branch 2 times, most recently from 9ab9a89 to d926d9b Compare April 28, 2024 03:05
@tuhaihe tuhaihe requested a review from TomShawn April 28, 2024 03:09
Copy link
Collaborator

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! My comments are mostly minor edits at the wording level.

i18n/zh/docusaurus-plugin-content-pages/contribute/code.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-pages/contribute/code.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-pages/contribute/code.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-pages/contribute/code.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-pages/contribute/code.md Outdated Show resolved Hide resolved
src/consts/contribute.tsx Outdated Show resolved Hide resolved
Reviewed-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@tuhaihe
Copy link
Member Author

tuhaihe commented May 7, 2024

@TomShawn thanks for your review work. 👍

Copy link
Collaborator

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuhaihe tuhaihe merged commit 3cb9482 into cloudberrydb:main May 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants