Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: translate some en docs #75

Merged
merged 5 commits into from
Apr 12, 2024
Merged

docs: translate some en docs #75

merged 5 commits into from
Apr 12, 2024

Conversation

TomShawn
Copy link
Collaborator

@TomShawn TomShawn commented Jan 17, 2024 •
edited

Translate some English docs into Chinese:

Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Contributor's checklist

Here are some reminders before you submit your pull request:

  • Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
  • Learn the code contribution and doc contribution guides for better collaboration.
  • Make sure that your changes deployment preview is successful.
  • List your communications in the GitHub Issues or Discussions (if has or needed).
  • Feel free to ask for the @cloudberrydb/doc team or other people to help review and approve.

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited

✅ Deploy Preview for cloudberrydb ready!

Name Link
🔨 Latest commit f9d5884
🔍 Latest deploy log https://app.netlify.com/sites/cloudberrydb/deploys/6618d5ff00cb02000858c06e
😎 Deploy Preview https://deploy-preview-75--cloudberrydb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TomShawn TomShawn force-pushed the translate-x-docs branch 2 times, most recently from f2d538b to fdfc2ed Compare February 29, 2024 05:50
@TomShawn TomShawn marked this pull request as ready for review March 4, 2024 10:22
@TomShawn TomShawn requested a review from tuhaihe March 4, 2024 10:22
tuhaihe
tuhaihe reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@tuhaihe tuhaihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left some comments for your information.

i18n/zh/docusaurus-plugin-content-docs/current/data-loading/load-data-from-web-services.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/data-loading/load-data-overview.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/data-loading/load-data-using-gpfdist.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/data-loading/load-data-using-gpfdist.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/update-stats-using-analyze.md Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/work-with-transactions.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Collaborator Author

TomShawn commented Mar 6, 2024

@tuhaihe All comments are addressed. PTAL again, thanks!

@TomShawn TomShawn requested a review from tuhaihe March 6, 2024 02:18
@tuhaihe
Copy link
Member

tuhaihe commented Mar 6, 2024

@tuhaihe All comments are addressed. PTAL again, thanks!

LGTM. Thanks!

tuhaihe
tuhaihe approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@tuhaihe tuhaihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tuhaihe tuhaihe requested a review from my-ship-it March 6, 2024 08:19
@TomShawn TomShawn merged commit 6ce26a9 into cloudberrydb:main Apr 12, 2024
6 checks passed
@TomShawn TomShawn deleted the translate-x-docs branch April 12, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuhaihe tuhaihe tuhaihe approved these changes

@my-ship-it my-ship-it Awaiting requested review from my-ship-it

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomShawn @tuhaihe