Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdbpath_motion_for_parallel_join() refactor #27

Closed
2 tasks done
avamingli opened this issue Jul 20, 2023 · 2 comments · Fixed by #98
Closed
2 tasks done

cdbpath_motion_for_parallel_join() refactor #27

avamingli opened this issue Jul 20, 2023 · 2 comments · Fixed by #98
Assignees
Labels
type: Refactoring A code change that neither fixes a bug nor adds a feature

Comments

@avamingli
Copy link
Collaborator

avamingli commented Jul 20, 2023

Cloudberry Database version

No response

What happened

cdbpath_motion_for_parallel_join() has most duplicated codes with cdbpath_motion_for_join(),
we separate them for clean codes.

Some codes are not used for parallel, for example, handle update in parallel mode is meaningless.
We have a refactor for SegmentGeneralWorkers as outer side, but lack for other locus.

By reviewing the codes, some potential bugs are found.
As this part of codes is critical, should fix them after refactor to avoid a big change.

What you think should happen instead

No response

How to reproduce

@tuhaihe This is exactly an enhancement, but I can't find a enhancement label or remove Bug label for it.

Some fields in this template are not suite for enhancement. And I can't set assignees either.

Operating System

no need

Anything else

No response

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@avamingli avamingli added the type: Bug Something isn't working label Jul 20, 2023
@tuhaihe tuhaihe added type: Enhancement New feature or request, ideas and removed type: Bug Something isn't working labels Jul 21, 2023
@tuhaihe
Copy link
Member

tuhaihe commented Jul 21, 2023

Hi @avamingli , I have helped updated your issue's label to type: Enhancement. The newly created issues are default labeled with type: Bug, only the people who have the triage privilege can update them.

/cc @my-ship-it Hi, Max, we need to redesign the org member roles for future collaborations.

@avamingli
Copy link
Collaborator Author

Hi @avamingli , I have helped updated your issue's label to type: Enhancement. The newly created issues are default labeled with type: Bug, only the people who have the triage privilege can update them.

/cc @my-ship-it Hi, Max, we need to redesign the org member roles for future collaborations.

Thanks for help:)

@avamingli avamingli added type: Refactoring A code change that neither fixes a bug nor adds a feature and removed type: Enhancement New feature or request, ideas labels Jul 24, 2023
@avamingli avamingli self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants