Refactor cdbpath_motion_for_parallel_join() by outer join inner style #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@my-ship-it This function is critical, to keep pr small, this commit doesn't cause any behavior change. Some wrong logic are found and left CBDB_PARALLEL_FIXME to remind us to resolve them in upcoming fixes. |
|
A suggestion for reviewers, it's hard to tell the right by codes diffs. |
avamingli
force-pushed
the
refactor_parallel_locus_join
branch
6 times, most recently
from
922038a
to
67aa72f
Compare
my-ship-it
approved these changes
Oct 8, 2023
avamingli
force-pushed
the
refactor_parallel_locus_join
branch
from
67aa72f
to
41b0295
Compare
We have separated join locus function for non-parallel and parallel mode into cdbpath_motion_for_join() which handles for locus whose parallel_workers is 0 and cdbpath_motion_for_parallel_join() which handles others. A lot of logic are meaningless in cdbpath_motion_for_parallel_join(): 1.Writeable operations for join. 2.Both sides's locus parallel_workers are no more than one. 3.Some locus couldn't participate parallel join yet now. We have done the job for SegmentGeneralWorkers as outer side join with other locus as inner side, but lack for other types. Refactoring that to keep codes clear. Some wrong logic are found and left CBDB_PARALLEL_FIXME to remind us to resolve them in upcoming fixes. Main changes: SingleQE join SegmentGeneralWorkers. SingleQE join Partitioned(workers>1), except HashedOJ. SegmentGeneral as outer, Assert(false). Partitioned(workers>1) join SegmentGeneral. Partitioned(workers>1) join SegmentGeneralWorkers. Partitioned(workers>1) join SingleQE. Partitioned join Partitioned are handled as cdbpath_motion_for_join(). Remove all if conditions for inner side locus. Authored-by: Zhang Mingli avamingli@gmail.com
avamingli
force-pushed
the
refactor_parallel_locus_join
branch
from
41b0295
to
eea7cf5
Compare
yjhjstz
approved these changes
Oct 9, 2023
|
Pushed, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have separated join locus function for non-parallel and parallel mode into cdbpath_motion_for_join() which handles for locus whose parallel_workers is 0 and cdbpath_motion_for_parallel_join() which handles others.
A lot of logic are meaningless in cdbpath_motion_for_parallel_join():
1.Writeable operations for join.
2.Both sides's locus parallel_workers are no more than one.
3.Some locus couldn't participate parallel join yet now.
We have done the job for SegmentGeneralWorkers as outer side join with other locus as inner side, but lack for other types. Refactoring that to keep codes clear.
Some wrong logic are found and left CBDB_PARALLEL_FIXME to remind us to resolve them in upcoming fixes.
Main changes:
SingleQE join SegmentGeneralWorkers.
SingleQE join Partitioned(workers>1), except HashedOJ.
SegmentGeneral as outer, Assert(false).
Partitioned(workers>1) join SegmentGeneral.
Partitioned(workers>1) join SegmentGeneralWorkers.
Partitioned(workers>1) join SingleQE.
Partitioned join Partitioned are handled as cdbpath_motion_for_join().
Remove all if conditions for inner side locus.
Authored-by: Zhang Mingli avamingli@gmail.com
closes: #27
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel