Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hashdata extension storage_am related hook, #135

Merged

Conversation

wangliang03
Copy link
Contributor

@wangliang03 wangliang03 commented Aug 10, 2023

All the QE will return its storage_am feature related meta data by control data tunnel,
we add hook when the QD processing the data returned from control data tunnel.

and also rewrite the check condiation for update scenario to make a wholerow attribute
for not only the appendonly table but all the tables except heap table including our
new hashdata involved table format.

closes: #ISSUE_Number


Change logs

for involving new hashdata table format extension , we need to a hook to process QE returned message,
also change a update scenario check condition to let new format table make a wholerow attribute.

If it has some breaking backward or forward compatibility, please clary.
no

Why are the changes needed?

currently there is no way to let the extension to control the message which QE returned on QD, we need a hook
to let the extension work its way.

Describe why the changes are necessary.
if there is such hook, extension cannot handle the message it returned from QE

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.
no

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
it is well test with my extension code, including insert./update/delete/select scenarios

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • [ x ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • [ x ] Sign the Contributor License Agreement as prompted for your first-time contribution.
  • [ x ] List your communication in the GitHub Issues or Discussions (if has or needed).
  • [ x ] Document changes.
  • [ x ] Add tests for the change
  • [ x ] Pass make installcheck
  • [ x ] Pass make -C src/test installcheck-cbdb-parallel
  • [ x ] Feel free to @cloudberrydb/dev team for review and approval when your PR is ready馃コ

  All the QE will return its storage_am feature related meta data by control data tunnel,
  we add hook when the QD processing the data returned from control data tunnel.

  and also rewrite the check condiation for update scenario to make a wholerow attribute
  for not only the appendonly table but all the tables except heap table including our
  new hashdata involved table format.
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiiii, @wangliang03 welcome!馃帄 Thanks for taking the effort to make our project better! 馃檶 Keep making such awesome contributions!

my-ship-it
my-ship-it previously approved these changes Aug 10, 2023
@my-ship-it my-ship-it merged commit 7127214 into cloudberrydb:main Aug 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants